[workspace] Upgrade drake_models to latest commit (fix plate_8in.gltf) #21442
Conversation
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @DamrongGuoy)
tools/workspace/drake_models/repository.bzl line 10 at r1 (raw file):
repository = "RobotLocomotion/models", commit = "01e6a611ab37002658841c37f04fd6b9d7163e2f", sha256 = "7220234af6fff351b55873e021a489889aac1de0eaf4d0505889451350246a34", # noqa
Working.
Working temporary SHA1 until the models PR RobotLocomotion/models#67 is merged.
Code quote:
commit = "01e6a611ab37002658841c37f04fd6b9d7163e2f",
sha256 = "7220234af6fff351b55873e021a489889aac1de0eaf4d0505889451350246a34", # noqa
DamrongGuoy
added
the
release notes: fix
There was a problem hiding this comment.
+@jwnimmer-tri for feature review, please.
CC: @amcastro-tri @SeanCurtis-TRI
I'm following the instruction in https://drake.mit.edu/model_version_control.html
To test the plate model files,
bazel run //tools:model_visualizer -- package://drake_models/dishes/plate_8in.sdf
and/or
bazel run //tools:meldis -- --open-window &
bazel run //examples/hydroelastic/ball_plate:ball_plate_run_dynamics
+(release notes: fix)
Thanks to Alejandro for reporting the problem.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
jwnimmer-tri
added
the
status: single reviewer ok
There was a problem hiding this comment.
Seems OK so far.
+(status: single reviewer ok)
Reviewed all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
DamrongGuoy
force-pushed
the
drake_models_fix_plate_8in.gltf
branch
from
08eaac5
to
ed65a12
Compare
There was a problem hiding this comment.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform)
tools/workspace/drake_models/repository.bzl line 10 at r1 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
Working.
Working temporary SHA1 until the models PR RobotLocomotion/models#67 is merged.
Done. The models PR 67 was merged. Use the new SHA1.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform)
|
https://drake-jenkins.csail.mit.edu/job/linux-jammy-gcc-bazel-experimental-debug/7627/ failed. @drake-jenkins-bot linux-jammy-gcc-bazel-experimental-debug please |
|
https://drake-jenkins.csail.mit.edu/job/linux-jammy-gcc-bazel-experimental-debug/7628/ also failed from the same CI buildcop issue #18726. I'll try again: |
|
I can just force it without waiting for Jenkins. Done. |
|
Thank you! |
Twin PR: RobotLocomotion/models#67
This change is