Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed window activation failure condition on macOS #93

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fixed window activation failure condition on macOS #93

wants to merge 2 commits into from

Conversation

seongmin-kim
Copy link

@seongmin-kim seongmin-kim commented Jan 3, 2018

Because of incorrect condition, I failed to activate a window with specified PID.
Follows are issues that related with this problem.
#robotgo/73

# line 1795

- if (AXUIElementPerformAction (window.mData->AxID, kAXRaiseAction) == kAXErrorSuccess) { /*...*/ }
+ if (AXUIElementPerformAction (window.mData->AxID, kAXRaiseAction) != kAXErrorSuccess) { /*...*/ }

dkrutsko and others added 2 commits August 13, 2017 17:35
# line 1795
- if (AXUIElementPerformAction (window.mData->AxID, kAXRaiseAction) == kAXErrorSuccess)
+ if (AXUIElementPerformAction (window.mData->AxID, kAXRaiseAction) != kAXErrorSuccess)
@seongmin-kim seongmin-kim changed the base branch from master to dev January 3, 2018 15:49
@dkrutsko
Copy link
Member

dkrutsko commented Jan 3, 2018

Thank you for this fix, I'll take a look and test this out!

@dkrutsko dkrutsko added the Bug An error or incorrect implementation label Mar 25, 2022
@dkrutsko dkrutsko added this to the Robot 2.1.0 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error or incorrect implementation
Development

Successfully merging this pull request may close these issues.

2 participants