-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added preprocessor directives for specific compilers #23
Open
Sqeaky
wants to merge
9
commits into
Robot:dev
Choose a base branch
from
Sqeaky:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ubuntu. Though in source builds are not a good idea, I added the common CMake files and files to the .gitignore.
…nd adjusted cmake output to make it easier to read. Building with shared libraries fails in visual studio with linker errors (probably easily resolved) build with static still works.
…ng list of source files, I corrected this and added target dependent preprocessor defintions.
…e compiler warnings and provides stronger guarantees going forward and in the event of platform changes.
…f NOMINMAX, Replacing ROBOT_OS_WIN with a comiler checks where appropriate, Added linking details to CMakeLists.txt and fixed a few unique items.
…rt for detecting the 4 supported versions of msvc, Clang, GCC and MinGW.
I am using @Sqeaky fork for creation of conan.io package (https://github.com/memsharded/conan-robot, https://www.conan.io/source/Robot/2.0/memsharded/testing), because it is more convenient having a CMakeLists.txt. So far, only tested VS14 and VS12, both static and shared linking, works great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added individual preprocessor macros for 4 msvc compiler, Clang, GCC and MinGw.
I also added a test function, TestPrepoc to the Process tests. This emits all the compiler macros and requests the user/tester visually inspect the result.
This is still from the same fork I made earlier. I think it ought to work seamlessly, but I have not attempted two requests from a single fork before.