Adding CMakeLists.txt to increase #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ubuntu. Though in source builds are not a good idea, I added the common CMake files and files to the .gitignore.
…nd adjusted cmake output to make it easier to read. Building with shared libraries fails in visual studio with linker errors (probably easily resolved) build with static still works.
…ng list of source files, I corrected this and added target dependent preprocessor defintions.
…e compiler warnings and provides stronger guarantees going forward and in the event of platform changes.
…f NOMINMAX, Replacing ROBOT_OS_WIN with a comiler checks where appropriate, Added linking details to CMakeLists.txt and fixed a few unique items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #17 . I have tested several configurations for windows and Ubuntu, including static and shared library configs with Clang, GCC, MinGW and visual studio community edition.
I am quite confident this will work with any Linux that is at all adheres to the LSB, like Red hat, Fedora and less so for Gentoo, Arch (I still think it'll work).
I do not have a Mac OS X machine to test with. But I suspect that will not work because it is missing some linking options.
There are a few functions that could be implemented better for MinGW, Process::Open I pretty much implemented as No-op. It also looks like a few shortcomings in the winuser.h and winbase.h implementation in the MinGW SDK, these will likely require bugfixes in MinGW.
Here are some things that this does not address that the previous build files do:
This does not address the install process.
This does not add "d" to the name.
Mac OS X linking options and Objective-C++ options are missing.
The Peon testing tool is not included.
This removed .BIN from the executable names.
I am unsure if I am missing any msvc options.