Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ball trail #130

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Feature/ball trail #130

wants to merge 3 commits into from

Conversation

PhiBabin
Copy link
Member

@PhiBabin PhiBabin commented May 4, 2019

Add a trail that follow the ball. This help track were the ball has pass. It's especially useful when checking if the ball entered the goal.
It needs to be test in real life with multiple ball. I think multiple balls will need a more complex solution, since you probably need to track the ball.
https://gph.is/g/ZkO33mZ

@TwistedSim
Copy link
Member

The BallTracker on StrategyAI keep track on the ball ID over time and should be pretty stable. The packet sent to the UIDebug should include this if it's not the case already.

@PhiBabin
Copy link
Member Author

PhiBabin commented May 4, 2019

The BallTracker on StrategyAI keep track on the ball ID over time and should be pretty stable. The packet sent to the UIDebug should include this if it's not the case already.

I will look into it. But the main problem with using a ball ID is that the goal of the line is to show the unfiltered position of the ball, not the filtered one. Are the vision packet send by ssl-vision use the same id for the same ball?

@PhiBabin
Copy link
Member Author

Tested irl. Multi ball is not handle correctly. We need to either reuse the ball position from the Ai (complexify the communications) or add a dump ball tracker in the ui (seem overkill).

@wonwon0
Copy link
Contributor

wonwon0 commented Jun 20, 2019

@PhiBabin merge!

@PhiBabin
Copy link
Member Author

This PR does not work if there are multiple balls. I could add an option to disable it, if it's annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants