Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

75: countdown timeouts review and removals #90

Merged
merged 15 commits into from
Dec 19, 2024

Conversation

mirage22
Copy link
Collaborator

code improvements

@mirage22 mirage22 requested a review from FDelporte December 14, 2024 19:25
@mirage22 mirage22 self-assigned this Dec 14, 2024
@mirage22 mirage22 closed this Dec 14, 2024
@mirage22 mirage22 deleted the feature/75-countdown-timeouts branch December 14, 2024 19:32
@mirage22 mirage22 restored the feature/75-countdown-timeouts branch December 14, 2024 19:32
@mirage22 mirage22 reopened this Dec 14, 2024
Copy link
Collaborator

@FDelporte FDelporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too complex for full review, quick look is OK

@mirage22 mirage22 merged commit 9cdd2bf into master Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants