Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

69: improve internal logging #77

Merged
merged 13 commits into from
Oct 14, 2024
Merged

69: improve internal logging #77

merged 13 commits into from
Oct 14, 2024

Conversation

mirage22
Copy link
Collaborator

@mirage22 mirage22 commented Oct 9, 2024

  • use slf4j
  • removal simple logging util
  • removal System.out.print*

@mirage22 mirage22 added hacktoberfest https://hacktoberfest.com/ hacktoberfest-accepted labels Oct 9, 2024
@mirage22 mirage22 self-assigned this Oct 9, 2024
@mirage22 mirage22 requested a review from FDelporte October 9, 2024 20:59
@mirage22 mirage22 mentioned this pull request Oct 13, 2024
Open
FDelporte
FDelporte approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@FDelporte FDelporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big change, but will make debugging a lot easier in my opinion. Thanks for adding a logger!

@mirage22 mirage22 merged commit e753ca0 into master Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FDelporte FDelporte FDelporte approved these changes

Assignees

@mirage22 mirage22

Labels
hacktoberfest https://hacktoberfest.com/ hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirage22 @FDelporte