Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client sync again #50

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Make client sync again #50

merged 1 commit into from
Nov 23, 2024

Conversation

kushudai
Copy link
Contributor

@kushudai kushudai commented Nov 23, 2024

What problem are we solving?

Consul was no longer sync because std's Sender not being Sync.

How are we solving the problem?

Using tokio's mpsc primitives instead.

Checks

Please check these off before promoting the pull request to non-draft status.

  • All CI checks are green.
  • I have reviewed the proposed changes myself.

@kushudai kushudai marked this pull request as ready for review November 23, 2024 02:30
@kushudai kushudai merged commit bf854b9 into main Nov 23, 2024
5 checks passed
@kushudai kushudai deleted the sync branch November 23, 2024 02:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant