Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read json from response buffer instead of copying #25

Closed
wants to merge 1 commit into from

Conversation

polachok
Copy link

@polachok polachok commented Jul 4, 2022

What problem are we solving?

mut and copy

How are we solving the problem?

removing mut and copy

Checks

Please check these off before promoting the pull request to non-draft status.

  • All CI checks are green.
  • I have reviewed the proposed changes myself.

@ChrisluRoblox
Copy link

Thanks for this PR. Is it possible to add some tests for this?

@github-actions
Copy link

CLA Signature Action:

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to our company's repositories.

0 out of 1 committers have signed the CLA.
@polachok

@kushudai
Copy link
Contributor

Hi @polachok thank you for this! Would you be willing to sign the CLA so we can accept this change?

@kushudai kushudai closed this Jul 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants