-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo in example.md #83
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to just use a placeholder. No reason for an actual phone number in example documentation.
Thanks for the approval. This isn't just about not using the actual number, I guess I wasn't very clear on the typo part. I've requested this to match the value with the "Expected Output" in your documentation, hope this helps.
|
Certainly does help. Thanks for the clarification. Either way it made sense, but with the additional information provided by yourself it further enhances why this PR should be accepted. Good spot & nice work 😊👍 |
Thank you for the contribution; please accept the SLA and I'd be glad to merge it |
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
No description provided.