Use less common port to avoid port conflicts #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othomson-roblox
approved these changes
Aug 31, 2023
|
OAuth2 app is now updated to additionally allow callbacks to port 8181 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the plugin uses port 8080 to start its localhost server listening for the oauth2 login callback.
This is a very common port used for alternative HTTP traffic. While the port selection makes sense, the fact that it's so common also raises the chance for conflicts with other applications.
This PR changes the port from 8080 to 8181, which is not a commonly used port but still resembles 8080 enough to indicate to a reader that it's used for http traffic.
This Wikipedia article has a nice list of commonly used port numbers to avoid, and it does not list 8181 as common.
This should help avoid issues like #12