APT-548 added generate-artifactory-path command to foreman #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,5 @@ | |||
| //After updating this file, consider updating artifactory_path.rs to reflect the operating systems and architectures that Foreman recognizes | |||
There was a problem hiding this comment.
I wish there was a better way to tie this together, but it doesn't seem like it. Luckily, since Matt added a fairly comprehensive set, it shouldn't need to change often.
| let path = generate_artifactory_path("repo", "tool_name", "v0.1.0", "macos", None).unwrap(); | ||
| assert_eq!( | ||
| path, | ||
| "artifactory/repo/tool_name/v0.1.0/tool_name-v0.1.0-macos.zip" |
There was a problem hiding this comment.
One interesting detail here is that the version number isn't duplicated in the github releases, but it also probably isn't a problem (we only really look for the os/arch keywords, iirc). I think we should be fine as is, but it's something to call attention to in case it affects our ability to share the artifact-choosing/download implementation.
Co-authored-by: Paul Doyle <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Foreman command generates a path that can be used to upload artifacts to Artifactory.