-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Vector3 to vector #943
base: main
Are you sure you want to change the base?
Migrate Vector3 to vector #943
Conversation
I do wonder if this would be merged or not (in its current state). Yes, the vector library is much more performant, it is also not complete yet from what I understand. This also creates an abstraction between Nonetheless, I would like to point out that you wrote |
My bad on the vector.new point, thanks for poiting that out. I'll commit a fix for that now. Was just quickly replacing Vector3 for vector haha! The extra functions of the vector library I was going to do in a later PR since I was aiming for the low hanging fruit but I can take a look at those too. |
PR #957 has been created by someone else to help with the migration. May update these pages to reference the new vector page instead of Vector3. |
Introduction
With the introduction of the Vector RFC seen in the release notes for 650
Changes
This PR migrates the documentation of Vector3 references to the new vector library where appropriate. Some references may need changing back due to the change required explained next.
More changes may be needed to make this request make sense to end users. Such as a dedicated page in the documentation for - the new library (Raised in PR #957 ), its application and methods - However this was out of scope for this PR.
This PR also compacts Vector3.new(0, 0, 0) to vector.zero where appropriate.
Please note that I understand that vector hasn't been properly announced yet and so this PR may need to sit for a little bit.
Checks
By submitting your pull request for review, you agree to the following: