Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TweenService.yaml #1000

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Update TweenService.yaml #1000

merged 5 commits into from
Jan 27, 2025
+16 −9

Conversation

sammygrey
Copy link
Contributor

Added additional info for TweenService:SmoothDamp. Includes summaries for all variables and the return value, default values for maxSpeed and dt, and changing the term "value" to "tuple."

@sammygrey
Update TweenService.yaml
5bc80d1 
Added additional info for TweenService:SmoothDamp. Includes summaries for all variables and the return value, default values for maxSpeed and dt, and changing the term "value" to "tuple."
@sammygrey sammygrey requested a review from a team as a code owner January 25, 2025 21:02
@github-actions github-actions bot added engine reference Changes the Engine API Reference documentation changes requested This pull request has changes requested prior to merging labels Jan 25, 2025
@sammygrey
Update TweenService.yaml
ac3e200 
I don't have permissions to change default values so guess thats scrapped.
@sammygrey
Update TweenService.yaml
621b132 
removed default variables
@sammygrey
Copy link
Contributor Author

Doesn't seem like I have the permission to change default variables, so I'll just include the changes I made in this comment:
maxSpeed: Default variable is Library.math.huge from what I've tested
dt: Default variable is the framerate of the context in which the Smoothing operation is being performed, different for local and server.
Credit to @MrHistory for bringing up these inconsistencies: https://devforum.roblox.com/t/documentation-for-tweenservice-smoothdamp/3413896

@IgnisRBX IgnisRBX merged commit 173a8d9 into Roblox:main Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@IgnisRBX IgnisRBX IgnisRBX approved these changes

Assignees
No one assigned
Labels
changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sammygrey @IgnisRBX