Support IsDryRun within http-request backend action #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
Still relevant |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Allow for http methods which should not modify resources to be executed under dry-run mode. This makes testing templates via dry-run that use data from http request action output to have their behaviour more reliably validated.
electrofelix
force-pushed
the
support-dry-run-http-request
branch
from
3b4f9e3 to
9bfc49e
Compare
punkle
approved these changes
Feb 8, 2024
punkle
reviewed
Feb 8, 2024
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@roadiehq/scaffolder-backend-module-http-request': patch | |||
There was a problem hiding this comment.
Its probably a minor, but not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for http methods which should not modify resources to be executed
under dry-run mode. This makes testing templates via dry-run that use
data from http request action output to have their behaviour more
reliably validated.