Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: project black and white lists #1192

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

Lucas-Desouza
Copy link
Contributor

@Lucas-Desouza Lucas-Desouza commented Nov 21, 2023

Adds the ability to set a black list or white list in the project created by the plugin.

This should allow the core application to limit what the projects can do. Currently projects created this way can create anything.

Before

Screenshot 2023-11-21 at 1 53 17 PM
Screenshot 2023-11-21 at 1 53 24 PM

After

Here is an example attempting to apply a cluster role binding.
Screenshot 2023-11-21 at 1 20 25 PM
Screenshot 2023-11-21 at 1 19 17 PM

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

@Lucas-Desouza Lucas-Desouza requested review from karlhaworth and a team as code owners November 21, 2023 19:56
@Lucas-Desouza Lucas-Desouza changed the title Project settings feat: project black and white lists Nov 21, 2023
karlhaworth
karlhaworth previously approved these changes Nov 24, 2023
Copy link
Collaborator

@karlhaworth karlhaworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Xantier Xantier merged commit cf896d4 into RoadieHQ:main Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants