Merge pull request #1248 from RoadieHQ/dont-log-internal-url

dont log the full url
RoadieHQ · Feb 9, 2024 · 5ab358e · 5ab358e
2 parents 5c3ce69 + f3965a0
commit 5ab358e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/orange-candles-cheer.md b/.changeset/orange-candles-cheer.md
@@ -0,0 +1,5 @@
+---
+'@roadiehq/scaffolder-backend-module-http-request': patch
+---
+
+Don't log the internal backend url.
diff --git a/...r-actions/scaffolder-backend-module-http-request/src/actions/run/backstageRequest.test.ts b/...r-actions/scaffolder-backend-module-http-request/src/actions/run/backstageRequest.test.ts
@@ -436,7 +436,7 @@ describe('http:backstage:request', () => {
           body: {},
         });
         const expectedLog =
-          "Dry run mode. Skipping non dry-run safe method 'POST' request to http://backstage.tests/api/proxy/foo";
+          "Dry run mode. Skipping non dry-run safe method 'POST' request to /api/proxy/foo";
         await action.handler({
           ...mockContext,
           input: {

diff --git a/...folder-actions/scaffolder-backend-module-http-request/src/actions/run/backstageRequest.ts b/...folder-actions/scaffolder-backend-module-http-request/src/actions/run/backstageRequest.ts
@@ -171,7 +171,9 @@ export function createHttpBackstageAction(options: {
       const dryRunSafeMethods = new Set(['GET', 'HEAD', 'OPTIONS']);
       if (ctx.isDryRun === true && !dryRunSafeMethods.has(method)) {
         ctx.logger.info(
-          `Dry run mode. Skipping non dry-run safe method '${method}' request to ${httpOptions.url}`,
+          `Dry run mode. Skipping non dry-run safe method '${method}' request to ${
+            queryParams !== '' ? `${input.path}?${queryParams}` : input.path
+          }`,
         );
         return;
       }