Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs about creating custom permission #1454

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

punkle
Copy link
Contributor

@punkle punkle commented Dec 18, 2024

No description provided.

@punkle punkle requested a review from a team December 18, 2024 13:49

## Introduction

**This feature is currently in the process of being rolled out. If you want access, please contact our support or sales teams.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend we make this more prominent. Thoughts on using an alert div?

<div role="alert">
  <div class="docs-cta__tip_title">Coming Soon</div>
  <div  class="docs-cta__tip_message">
    <p>This feature is currently in the process of being rolled out. If you want access, please contact our support or sales teams.</p>
  </div>
</div>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@punkle ☝️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already a pattern I am copying from another page.. Id suggest if we are improving this we should make the change across the other pages as part of another commit.

Its a good suggestion though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is something I'm trying to move towards as we write new documentation. I have used it in multiple pages already, an example would be on step 18 of the Track Fragments recipe. If you prefer, we can do a bulk update, but I've been doing greenfield page as I create them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant. Im all on for it. Let me know if i can help.

@punkle punkle merged commit 0e6521e into main Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants