-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs about creating custom permission #1454
Conversation
Quality Gate passedIssues Measures |
|
||
## Introduction | ||
|
||
**This feature is currently in the process of being rolled out. If you want access, please contact our support or sales teams.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend we make this more prominent. Thoughts on using an alert div?
<div role="alert">
<div class="docs-cta__tip_title">Coming Soon</div>
<div class="docs-cta__tip_message">
<p>This feature is currently in the process of being rolled out. If you want access, please contact our support or sales teams.</p>
</div>
</div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@punkle ☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already a pattern I am copying from another page.. Id suggest if we are improving this we should make the change across the other pages as part of another commit.
Its a good suggestion though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is something I'm trying to move towards as we write new documentation. I have used it in multiple pages already, an example would be on step 18 of the Track Fragments recipe. If you prefer, we can do a bulk update, but I've been doing greenfield page as I create them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant. Im all on for it. Let me know if i can help.
No description provided.