Display values diff on upgrade #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dtuite
commented
Apr 9, 2020
•
dtuite
commented
- Display a diff when a chart is upgraded or rolled back.
- Put this behind a flag and disable it by default to protect leaks
- Add the config in the readme.
- Add in the config in the docs.
- Add a blacklist or whitelist solution.
Only show diff if non-empty string - Disabled by default to prevent sensitive values from being leaked. - Also changed website in Chart.yaml - Added to readme
cep21
reviewed
Apr 19, 2020
| @@ -38,6 +41,8 @@ func (e *Event) Init() error { | |||
| e.currentRelease = e.GetRelease(e.CurrentReleaseSecret.Name) | |||
| e.previousRelease = e.getPreviousRelease() | |||
|
|
|||
| e.GetConfigDiffYAML() | |||
There was a problem hiding this comment.
Why call this if you don't capture the return value
There was a problem hiding this comment.
Good catch. That's a mistake. I was just forcing it to run during development so the diff would be logged. I removed the log line but forgot to remove this.
I wasn't expecting anyone to review it so I just merged it to master but I will remove this now.
There was a problem hiding this comment.
I'm going to tackle the issue with sensitive values being leaked in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.