Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump rspec-sidekiq from 3.1.0 to 5.0.0 #194

Open
wants to merge 1 commit into
base: legacy/plaza
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Sep 20, 2024

Bumps rspec-sidekiq from 3.1.0 to 5.0.0.

Release notes

Sourced from rspec-sidekiq's releases.

v5.0.0

Breaking ❗

  • have_enqueued_sidekiq_job() matches jobs with any arguments (same as enqueue_sidekiq_job() or have_enqueued_sidekiq_job(any_args)). Previously it would only match jobs with no args (#215)

New features ✨

You can now specify the number of jobs that should match the expectation! Thanks you @​3v0k4 for the much requested feature!

Use via one of the following chainable methods:

  • #once
  • #twice
  • #thrice
  • #exactly(n)
  • #at_least(n)
  • #at_most(n)

Examples:

expect(AwesomeJob).to have_enqueued_sidekiq_job.once
expect(AwesomeJob).to have_enqueued_sidekiq_job.exactly(1).time
expect(AwesomeJob).to have_enqueued_sidekiq_job.exactly(:once)
expect(AwesomeJob).to have_enqueued_sidekiq_job.at_least(1).time
expect(AwesomeJob).to have_enqueued_sidekiq_job.at_least(:once)
expect(AwesomeJob).to have_enqueued_sidekiq_job.at_most(2).times
expect(AwesomeJob).to have_enqueued_sidekiq_job.at_most(:twice)
expect(AwesomeJob).to have_enqueued_sidekiq_job.at_most(:thrice)

PR Changelog

Full Changelog: wspurgin/rspec-sidekiq@v4.2.0...v5.0.0

As always, bug reports and additions are always most welcome!

v4.2.0

What's Changed

New Contributors

Full Changelog: wspurgin/rspec-sidekiq@v4.1.0...v4.2.0

... (truncated)

Changelog

Sourced from rspec-sidekiq's changelog.

5.0.0

  • [BREAKING] Make have_enqueued_sidekiq_job() match jobs with any arguments (same as enqueue_sidekiq_job() or have_enqueued_sidekiq_job(any_args)) (#215)
  • Add support for expected number of jobs to both enqueue_sidekiq_job and have_enqueued_sidekiq_job (#219)

4.2.0

  • Add warning about have_enqueued_sidekiq_job with no arguments (default will change in next major release) (#216, #217)

4.1.0

  • Add Composable support to enqueue_sidekiq_job and have_enqueued_sidekiq_job (#211)
  • Add immediately to specify that a job should be enqueued without any delay (#210)

4.0.2

  • Explicitly require forwardable (#204)

4.0.1

  • Restore the old normalizing expected args behavior with symbols (#205)
    • fixes an unintentional breaking change in 4.0.0

4.0.0

  • [BREAKING] Dropped support for matching jobs on ActiveJob's private API args, (e.g. _aj_globalid and _aj_ruby2_keywords). _aj_globalid can be replaced with the object itself, e.g. have_enqueued_sidekiq_job(user).
  • [BREAKING] Dropped support for Ruby 2.6
  • [BREAKING] Mocking Sidekiq::Batch is now opt in (was opt-out) by default
  • [BREAKING] Dropped the have_enqueued_job matcher (deprecated since v3)
  • [BREAKING] Dropped support for Sidekiq <5
  • [BREAKING] Dropped support for Rails 5
  • Add support for Sidekiq 7 (#192)
  • Add support for builtin argument matchers from rspec mocks for have_enqueued_sidekiq_job (#200)
  • Add #on to have_enqueued_sidekiq_job to support testing queue at enqueue time (#197)
  • Add enqueue_sidekiq_job for block-syntax style expectations
  • Clarified have_enqueued_sidekiq_job error message to make it clear that the "actual arguments" list is an array of argument-lists across all enqueued jobs. (#195)
  • Fix in and at evaluation to match Sidekiq (#194)
  • Fix be_delayed argument matcher (#196)
  • Fix argument matching ignoring order (#200)
  • Fix be_delayed time math when using delay_for (#198)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rspec-sidekiq](https://github.com/wspurgin/rspec-sidekiq) from 3.1.0 to 5.0.0.
- [Release notes](https://github.com/wspurgin/rspec-sidekiq/releases)
- [Changelog](https://github.com/wspurgin/rspec-sidekiq/blob/main/CHANGES.md)
- [Commits](wspurgin/rspec-sidekiq@v3.1.0...v5.0.0)

---
updated-dependencies:
- dependency-name: rspec-sidekiq
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Sep 20, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants