Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added percentage deduction amount #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added percentage deduction amount #114

wants to merge 1 commit into from

Conversation

keshavgoyal97
Copy link
Contributor

@keshavgoyal97 keshavgoyal97 requested a review from a team as a code owner January 23, 2025 09:09
vmaniar-rippling
vmaniar-rippling reviewed Jan 25, 2025
View reviewed changes
flux_sdk/pension/capabilities/report_payroll_contributions/data_models.py
@@ -104,6 +104,8 @@ class PayrollRunContribution:
"""
deduction_type: ContributionType
amount: Decimal
deduction_amount: Decimal
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add each class property details. This will help consumer to understand it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaniar-rippling vmaniar-rippling vmaniar-rippling left review comments

@ujjwalshukla ujjwalshukla ujjwalshukla approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keshavgoyal97 @ujjwalshukla @vmaniar-rippling