Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

League director scans the windows registry for League of Legends game client #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 0.1.5
- Fix detection of League of Legends game clients

## 0.1.4
- Upgrade to Qt 6.6.3.1
- Upgrade to Python 3.11.9
Expand Down
2 changes: 1 addition & 1 deletion build/install.iss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[Setup]
AppName=League Director
AppVersion=0.1.4
AppVersion=0.1.5
AppVerName=League Director
DisableDirPage=no
DefaultDirName={pf}\League Director
Expand Down
2 changes: 1 addition & 1 deletion leaguedirector/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.1.4"
__version__ = "0.1.5"
6 changes: 2 additions & 4 deletions leaguedirector/enable.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@ def findWindowsInstalled(paths):
"""
Find games installs in the windows registry.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Find games installs in the windows registry.
Find games install in the windows registry.

"""
settings = QSettings('HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node', QSettings.NativeFormat);
settings.beginGroup('Riot Games, Inc')
settings = QSettings('HKEY_CURRENT_USER\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall', QSettings.NativeFormat);
for key in settings.allKeys():
if key.endswith('/Location'):
if key.startswith('Riot Game league_of_legends') and key.endswith('InstallLocation'):
paths.append(settings.value(key))
settings.endGroup()

def findWindowsRunning(paths):
"""
Expand Down