Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove unnecessary and deprecated rules #166

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: remove unnecessary and deprecated rules #166

merged 1 commit into from
Jul 9, 2024

Conversation

frantic1048
Copy link
Contributor

@frantic1048 frantic1048 commented Jul 8, 2024 •
edited
Loading

This PR resolves the step 2 of #159

This PR depends on #160

  1. Reduced redundant rule overrides.
  2. Removed useless rule configs.
  3. Style related rules.
    1. Removed rules that conflict with Prettier (This make us no longer need to ship eslint-config-prettier as a dependency).
    2. Added test to check conflicts with Prettier.
    3. Migrated deprecated style rules to @stylistic/js counterparts.
  4. Legacy rules (prior ESLint v8 )
    1. Removed/Migrated deprecated rules, except these ones(currently the have no ideal replacement, we may fix these rules later):
      • no-buffer-constructor
      • no-return-await
    2. Added test to check deprecated rules.

For detailed rule changes, please see https://github.com/RightCapitalHQ/frontend-style-guide/pull/166/files#diff-6a7b668335f2224bcd651ef1b8dd12c5e8ac3915e02590617e73529a6b5237ce

@frantic1048 frantic1048 added the enhancement New feature or request label Jul 8, 2024
@frantic1048 frantic1048 changed the title Feature/remove unnecessary and deprecated rules feat: remove unnecessary and deprecated rules Jul 8, 2024
@frantic1048 frantic1048 mentioned this pull request Jul 8, 2024
Open
3 tasks
@frantic1048 frantic1048 self-assigned this Jul 8, 2024
@frantic1048 frantic1048 marked this pull request as draft July 8, 2024 09:02
@frantic1048 frantic1048 mentioned this pull request Jul 9, 2024
Merged
@frantic1048 frantic1048 force-pushed the feature/remove-unnecessary-and-deprecated-rules branch 7 times, most recently from 3b58e05 to 2d2d5d4 Compare July 9, 2024 08:48
@frantic1048 frantic1048 requested review from lixiaoyan and liby July 9, 2024 08:54
@frantic1048 frantic1048 marked this pull request as ready for review July 9, 2024 08:54
@frantic1048 frantic1048 force-pushed the feature/remove-unnecessary-and-deprecated-rules branch from 2d2d5d4 to 5ba959f Compare July 9, 2024 09:07
@frantic1048 frantic1048 requested a review from liby July 9, 2024 09:41
@frantic1048 frantic1048 merged commit e164a1e into main Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liby liby liby approved these changes

@lixiaoyan lixiaoyan Awaiting requested review from lixiaoyan

Assignees

@frantic1048 frantic1048

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frantic1048 @liby