Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for nixpkgs breaking change #669

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

importantblimp
Copy link
Contributor

@importantblimp importantblimp commented May 11, 2024

Summary

While doing due diligence for NixOS/nixpkgs#180654 I noticed this repository has documentation for enabling Kime on NixOS.
The fix for 180654 is a breaking change, so this PR updates the Kime documentation.

I haven't updated the changelog because this is a NixOS breaking change, and is documented in the NixOS breaking changes for release 24.11.
Existing non-NixOS users are unaffected, and existing NixOS users will be informed when they update to 24.11.
New users in both cases are unaffected.

Checklist

  • I have documented my changes properly to adequate places
  • I have updated the docs/CHANGELOG.md

@importantblimp importantblimp marked this pull request as draft May 11, 2024 08:11
@importantblimp
Copy link
Contributor Author

The nixpkgs review has been marked as a draft, pending the end of the breaking changes window and some changes to the PR

@importantblimp importantblimp force-pushed the fix-nixpkgs-breaking-change branch from 1063be8 to 289be0f Compare July 14, 2024 00:55
@importantblimp
Copy link
Contributor Author

The change is now present in NixOS/nixpkgs@9665639 and, although the change is no longer breaking, enabled has been deprecated and will be removed in a future release

@importantblimp importantblimp marked this pull request as ready for review July 14, 2024 00:58
@Riey Riey force-pushed the fix-nixpkgs-breaking-change branch from 289be0f to 37779a8 Compare July 14, 2024 04:16
@Riey Riey merged commit b765265 into Riey:develop Jul 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants