Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netstandard #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Netstandard #12

wants to merge 6 commits into from

Conversation

Jeern
Copy link

@Jeern Jeern commented Oct 4, 2018

Hi,

I have a ASP.NET Core project that uses Markdig(which have a .NET Standard edition) , since your Nuget package Markdig.SyntaxHighlighting did not have a .NET Standard edition I could not use it,

In this PR:

I have changed the library from the old fashioned Portable library, to a .NET Standard library. Which can be used almost everywhere.

I have changed the Unittest project to a .NET Core project. None of your code has changed except one line in a unittest.

All tests run fine.

I have referenced the Markdig.SyntaxHighlighting.dll from my package and it also works fine there.

I have taken care to use your SharedAssemblyInfo.cs in the new projects

In other words it should be Ok to accept this Pull Request, unless you still want to maintain the obsolete Portable library ?

Hope you can use it.

Regards Jesper

@Jeern
Copy link
Author

Jeern commented Oct 4, 2018

I can see you have an AppVeyour build that would fail with my PR. Probably AppVeyour just needs to be configured to build it in another way because it is a new project type. Anyway - I still hope you can use the PR. It would certainly improve the reach of your Nuget package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant