Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a ASP.NET Core project that uses Markdig(which have a .NET Standard edition) , since your Nuget package Markdig.SyntaxHighlighting did not have a .NET Standard edition I could not use it,
In this PR:
I have changed the library from the old fashioned Portable library, to a .NET Standard library. Which can be used almost everywhere.
I have changed the Unittest project to a .NET Core project. None of your code has changed except one line in a unittest.
All tests run fine.
I have referenced the Markdig.SyntaxHighlighting.dll from my package and it also works fine there.
I have taken care to use your SharedAssemblyInfo.cs in the new projects
In other words it should be Ok to accept this Pull Request, unless you still want to maintain the obsolete Portable library ?
Hope you can use it.
Regards Jesper