Properly disable logs on Release build

src/logging.cpp

@@ -19,7 +19,7 @@ void logging::SetupLogger() {
     spdlog::set_level(spdlog::level::trace);
 #else
     // don't output logs if envvar is not defined
-    return;
+    spdlog::set_level(spdlog::level::off);
 #endif
   }
   else spdlog::cfg::helpers::load_levels(envLogLevel);
@@ -40,6 +40,10 @@ void logging::SetupLogger() {
 }
 
 void logging::SetLoggerFileName(const std::string& fileName) {
+  /* Return early if logs are off, so files are not created */
+  if ( spdlog::get_level() == spdlog::level::off )
+    return;
+
   try {
     const auto logger = spdlog::basic_logger_mt("file",
       fileName, true);