Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hitags sim: apply correct coding after select(uid) #2591

Closed
wants to merge 1 commit into from

Conversation

n0emis
Copy link
Contributor

@n0emis n0emis commented Oct 26, 2024

in the current sim, the anticoll coding is still used after the tag has been selected. this patch ensures, that the corresponding mc coding is used after select(uid)

Copy link

You are welcome to add an entry to the CHANGELOG.md as well

@douniwan5788
Copy link
Contributor

The issue should be fixed in #2587. Could you retest in the latest master branch?

@n0emis
Copy link
Contributor Author

n0emis commented Oct 27, 2024

Hmm, not sure what is going on here. Either this breaks the simulator fully or I'm holding it wrong.

e.g. no command is received by the proxmark:

hw dbg -4
lf hitag hts reader
[#] RX0 0:00.. err:1 resptime:449 h2:0 h3:0 h4:0 edges:
[#] 0c
[#] UID Request failed!
[#] DEBUG: Error - failed getting UID

and no output by the simulating proxmark

@n0emis
Copy link
Contributor Author

n0emis commented Oct 27, 2024

okay, there was an issue with the timing, see #2595

but the coding is still not working right.

[#] hts_set_frame_modulation: set m to 2 (mode 200)
[#] UID request: length: 5 first byte: c0
[#] HT_ADVANCED
[#] hts_set_frame_modulation: set m to 0 (mode 192)
[#] hitag_send_frame: coding 0
[#] hitag_send_frame: (32) 5F C2 11 84
[#] hts_set_frame_modulation: set m to 2 (mode 192)
[#] SELECT
[#] SELECT match
[#] hitag_send_frame: coding 0
[#] hitag_send_frame: (40) CA 00 00 FF

somewhere between hts_set_frame_modulation and hitag_send_frame the modulation changes, but I can't find any reference to m. not sure what is happening here

@n0emis
Copy link
Contributor Author

n0emis commented Oct 27, 2024

see #2520 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants