improve Hitag S output #2579
improve Hitag S output #2579
Conversation
|
You are welcome to add an entry to the CHANGELOG.md as well |
| @@ -37,28 +37,45 @@ | |||
| static int CmdHelp(const char *Cmd); | |||
|
|
|||
| static const char *hts_get_type_str(uint32_t uid) { | |||
| // source 1: https://www.scorpio-lk.com/downloads/Tango/HITAG_Classification.pdf | |||
| // IDE Mark | |||
| // Each HITAG chip contains an unique Device Identifier (IDE ) so called a Serial Number. | |||
There was a problem hiding this comment.
Unique Identifier ( UID ) 4 bytes. its not IDE..
There was a problem hiding this comment.
Simply copy/paste from the unofficial HITAG_Classification.pdf. I'm confused about the strange abbreviation "IDE" too. I can't find anything on the internet about the "IDE mark" except in the PDF itself. I don't even know if it's really applicable to Hitag S.
There was a problem hiding this comment.
I never heard of IDE mark too.
In NXP official documents its UID.
client/src/cmdlfhitaghts.c
Outdated
| return ""; | ||
| } | ||
| uint8_t pid0 = uid & 0xF; | ||
| uint8_t pid1 = (uid >> 4) & 0xF; |
There was a problem hiding this comment.
I suggest using defines NIBBLE_HIGH and NIBBLE_LOW
There was a problem hiding this comment.
Sweet, I didn't notice that. Handy!
|
|
||
| // access right | ||
| if (page_addr == HITAGS_UID_PADR) { | ||
| PrintAndLogEx(NORMAL, _RED_("RO ")NOLF); |
There was a problem hiding this comment.
RED for read only might be a bit too harsh. How about we just let it be normal white?
There was a problem hiding this comment.
I'm try to following the lf hitag read --ht2 color scheme. Read-only is usually normal for the UID page. However, for other pages, it means they are locked.
There was a problem hiding this comment.
We need a better unified color scheme.
|
Good improvements, this needs to be a bit adjusted to fit into the pm3 client style. |
douniwan5788
force-pushed
the
82xx_print
branch
from
b927952
to
2ac74e0
Compare
No description provided.