Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mfc_default_keys.dic With more keys #2211

Closed
wants to merge 1 commit into from

Conversation

PommyGit
Copy link

Just added a bunch of keys to the dictionary

Just added a bunch of keys to the dictionary

Signed-off-by: PommyGit <[email protected]>
Copy link

You are welcome to add an entry to the CHANGELOG.md as well

@iceman1001
Copy link
Collaborator

Nice,

Before any merging we need to sort out if these keys are confirmed static default keys. Ie: are these keys to be the same on multiple cards from the same system, or are they unique on each card.

And from which system do these keys come from?

@PommyGit
Copy link
Author

These keys are from the Transperth Smartrider system. I generally always have zero success when using hf mf autopwn on such cards but since i started gathering the list using hf mf autopwn -f ./my-key-collection.dic is alwasys a resounding success. I hope that answers your question

@iceman1001
Copy link
Collaborator

Good, Lets see what metrodroid project says, https://github.com/metrodroid/metrodroid/wiki/SmartRider#key-diversification

They concluded that there are some static keys and some diversified.

Now which ones in your list fits their blocks for static keys? Since those we want in the default key list,

@iceman1001
Copy link
Collaborator

You also have lots of duplicates in your keys. That needs to be addressed too.

@s00se
Copy link
Contributor

s00se commented Dec 31, 2023

Looks like only unique keys are:

117E5C165B10
2031D1E57A3B
24BB421C7973
3E3A546650EA
41F262D3AB66
4B791BEA7BCC
514956AB3142
568C9083F71C
5C8FF9990DA2
75CCB59C9BED
863933AE8388
9189449EA24E
D01AFEEB890A

@PommyGit
Copy link
Author

PommyGit commented Jan 1, 2024

Strange how I unique this in bash and this was the output. Sorry for the sloppiness. I'm AFK at the Mo but will address these issues asap including the link to the static keys that @iceman1001 posted. Sorry guys.

@iceman1001
Copy link
Collaborator

I will close this one, since I pushed @s00se PR and his post of unique keys here.

@PommyGit you can verify that short list of keys against the link and make a new PR if needed.

Thanks!

@iceman1001 iceman1001 closed this Jan 1, 2024
@iceman1001
Copy link
Collaborator

and no... that wasn't unique.. I removed the duplicates...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants