-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-LF-emulation #221
fix-LF-emulation #221
Conversation
You are welcome to add an entry to the CHANGELOG.md as well |
Built artifacts for commit c7d6224FirmwareClient |
Havent tested it on a real reader yet, but it definitely works with flipper0! So this is a progress, many thanks! |
@alexbilevskiy Thanks a lot, hope it would be useful. Did you have any related problems before? |
LF emulation didn't work at all on my CU |
Has anyone tested and provided more feedback on the test results? |
@Dmytro02 in discord REALLY stressed the point that this needs to be reworked in his opinion, so maybe merging as is isnt the best idea? |
It is not. It is just proof of concept. Maybe, if possible, we can rework this part with @doegox (Philippe Teuwen), as I can see he is the main author of this functionality. And together, I believe, we will properly fix the issue. |
worked on the bootleg ones |
Hello @mitmarcus , |
By bootleg I meant a chamele0n Sadly when I purchased, I got this one instead of the original. However, EM4100X worked countless times without problems on at least 3 separate types of readers ¯\_(ツ)_/¯ |
Hey, @Dmytro02 I have just tested your branch and can confirm that the emulation with your changes works well. tested with Flipper Zero. Unfortunately, I don't have a real EM4100 reader nearby |
Hello @Semper-Viventem, I hope you and your family are doing well these last few days. Thanks for your report. Could you also share some details about how the emulation worked before, please? |
@Dmytro02, thank you, the wildfire is crazy but we are fine! I wasn't able to successfully read the emulated EM41** tags in either v2.0.0 or v.1.0 firmware revision (using Flipper Zero as a reader). Only after building your fix the emulation was fine. But I assume that it might be some Flipper-related behavior as I don't have any other EM41* readers available. |
@Semper-Viventem Thanks for the replay. I have two readers (one is self-made), and both could not read the CU before this dirty fix;). I hope @doegox will someday have some inspiration to merge it into the main branch. |
Hello, I can merge but before, please rephrase your comments in the code. It's awkward to say "my reader" and "my point of view" in the middle of an open source code. Feel free to express your personal experience in the commit message but not in the code comments. Thanks. |
Hello @doegox. Thanks for your point, I have cleaned up the comments. I'll be glad if this fix helps. |
thank you ! |
The original EM4100 tag continuously sends its ID.
The root problem, in my point of view, was that CU started to "feel" the field too far to be able to modulate it deep enough,
and 3 times (LF_125KHZ_BROADCAST_MAX) of repeating takes only about 100ms, CU is still not close enough to the reader.
That is why the emulation worked only if the CU moved past the reader quickly (fly by).