Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-LF-emulation #221

Merged
merged 3 commits into from
Jan 14, 2025
Merged

fix-LF-emulation #221

merged 3 commits into from
Jan 14, 2025

Conversation

Dmytro02
Copy link

@Dmytro02 Dmytro02 commented Aug 5, 2024

The original EM4100 tag continuously sends its ID.
The root problem, in my point of view, was that CU started to "feel" the field too far to be able to modulate it deep enough,
and 3 times (LF_125KHZ_BROADCAST_MAX) of repeating takes only about 100ms, CU is still not close enough to the reader.
That is why the emulation worked only if the CU moved past the reader quickly (fly by).

Copy link

github-actions bot commented Aug 5, 2024

You are welcome to add an entry to the CHANGELOG.md as well

Copy link

github-actions bot commented Aug 5, 2024

Built artifacts for commit c7d6224

Firmware

Client

@alexbilevskiy
Copy link

Havent tested it on a real reader yet, but it definitely works with flipper0! So this is a progress, many thanks!

@Dmytro02
Copy link
Author

Dmytro02 commented Aug 7, 2024

Havent tested it on a real reader yet, but it definitely works with flipper0! So this is a progress, many thanks!

@alexbilevskiy Thanks a lot, hope it would be useful. Did you have any related problems before?

@alexbilevskiy
Copy link

Did you have any related problems before?

LF emulation didn't work at all on my CU

@xianglin1998
Copy link
Contributor

Has anyone tested and provided more feedback on the test results?

@GameTec-live
Copy link
Contributor

@Dmytro02 in discord REALLY stressed the point that this needs to be reworked in his opinion, so maybe merging as is isnt the best idea?

@Dmytro02
Copy link
Author

Dmytro02 commented Aug 12, 2024

It is not. It is just proof of concept. Maybe, if possible, we can rework this part with @doegox (Philippe Teuwen), as I can see he is the main author of this functionality. And together, I believe, we will properly fix the issue.

@mitmarcus
Copy link
Contributor

Did you have any related problems before?

LF emulation didn't work at all on my CU

worked on the bootleg ones

@Dmytro02
Copy link
Author

Did you have any related problems before?

LF emulation didn't work at all on my CU

worked on the bootleg ones

Hello @mitmarcus ,
could you please add some more details?

@mitmarcus
Copy link
Contributor

mitmarcus commented Aug 15, 2024

By bootleg I meant a chamele0n

Sadly when I purchased, I got this one instead of the original. However, EM4100X worked countless times without problems on at least 3 separate types of readers ¯⁠\⁠_⁠(⁠ツ⁠)⁠_⁠/⁠¯

@Semper-Viventem
Copy link

Hey, @Dmytro02 I have just tested your branch and can confirm that the emulation with your changes works well. tested with Flipper Zero. Unfortunately, I don't have a real EM4100 reader nearby

@Dmytro02
Copy link
Author

Hey, @Dmytro02 I have just tested your branch and can confirm that the emulation with your changes works well. tested with Flipper Zero. Unfortunately, I don't have a real EM4100 reader nearby

Hello @Semper-Viventem, I hope you and your family are doing well these last few days. Thanks for your report. Could you also share some details about how the emulation worked before, please?

@Semper-Viventem
Copy link

@Dmytro02, thank you, the wildfire is crazy but we are fine! I wasn't able to successfully read the emulated EM41** tags in either v2.0.0 or v.1.0 firmware revision (using Flipper Zero as a reader). Only after building your fix the emulation was fine. But I assume that it might be some Flipper-related behavior as I don't have any other EM41* readers available.

@Dmytro02
Copy link
Author

@Dmytro02, thank you, the wildfire is crazy but we are fine! I wasn't able to successfully read the emulated EM41** tags in either v2.0.0 or v.1.0 firmware revision (using Flipper Zero as a reader). Only after building your fix the emulation was fine. But I assume that it might be some Flipper-related behavior as I don't have any other EM41* readers available.

@Semper-Viventem Thanks for the replay. I have two readers (one is self-made), and both could not read the CU before this dirty fix;). I hope @doegox will someday have some inspiration to merge it into the main branch.

@doegox
Copy link
Contributor

doegox commented Jan 11, 2025

Hello, I can merge but before, please rephrase your comments in the code. It's awkward to say "my reader" and "my point of view" in the middle of an open source code. Feel free to express your personal experience in the commit message but not in the code comments. Thanks.

@Dmytro02
Copy link
Author

Hello, I can merge but before, please rephrase your comments in the code. It's awkward to say "my reader" and "my point of view" in the middle of an open source code. Feel free to express your personal experience in the commit message but not in the code comments. Thanks.

Hello @doegox. Thanks for your point, I have cleaned up the comments. I'll be glad if this fix helps.

@doegox doegox merged commit d6c106f into RfidResearchGroup:main Jan 14, 2025
8 checks passed
@doegox
Copy link
Contributor

doegox commented Jan 14, 2025

thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants