Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for mifare classic value block operations #180

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

taichunmin
Copy link
Contributor

@taichunmin taichunmin commented Oct 25, 2023

Added support for mifare classic value block operations

@taichunmin taichunmin marked this pull request as draft October 25, 2023 00:20
@github-actions
Copy link

You are welcome to add an entry to the CHANGELOG.md as well

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Built artifacts for commit e795682

Firmware

Client

@taichunmin taichunmin changed the title Added mf1 increment/decrement/restore/transfer cmd Added support for mifare classic value block operations Oct 25, 2023
@taichunmin
Copy link
Contributor Author

taichunmin commented Oct 25, 2023

I didn't know how to implement send bytes to tag and then wait for response nack or timeout (which means success) in mf value operation.

Currently the code didn't send all the data to tags. sometimes 0 bit and sometime 1 bit.

截圖 2023-10-25 上午9 08 00 截圖 2023-10-25 上午10 02 16

docker-compose.yml Outdated Show resolved Hide resolved
@taichunmin taichunmin force-pushed the taichunmin branch 7 times, most recently from 549d378 to 614bbe1 Compare October 25, 2023 14:53
@taichunmin taichunmin marked this pull request as ready for review October 25, 2023 14:53
@taichunmin taichunmin requested a review from doegox October 25, 2023 14:55
@doegox doegox merged commit 5b67a89 into RfidResearchGroup:main Nov 15, 2023
8 checks passed
@doegox
Copy link
Contributor

doegox commented Nov 15, 2023

I didn't test specifically the new value block operations but I did some tests to make sure existing 14a support for raw, mfu etc was still working fine, so good enough for a merge ;)

@taichunmin taichunmin deleted the taichunmin branch November 15, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants