Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase initial button wakeup from 4 to 8 seconds #152

Closed
wants to merge 1 commit into from

Conversation

aramova
Copy link
Contributor

@aramova aramova commented Sep 15, 2023

Initial button press wakeup of 4 seconds is sometimes inadequate to establish BT connection.

This change will expand the Initial button wakeup from 4 seconds to 8 seconds.

Device sleep behavior after will be as follows:
(Changed)
Initial Button Wakeup to Sleep : 8s
(No Change)
Subsequent Button Action to Sleep : 4s
Leaving RF Field wake to sleep : 3s
BLE Disconnect to sleep : 4s
USB Power Disconnect to sleep : 3s

Example behavior :
User wakes device with Button B (8 Sec to sleep)
User pushes button B again (Now 4 Sec to sleep)
User Places device in RF field (Maintain wake)
User removes device from RF field (3 sec to sleep)

If user discontinues the user journey at any point, the identified condition will invoke sleep at defined times.

Initial button press wakeup of 4 seconds is sometimes inadequate to establish BT connection. 

This change will expand the Initial button wakeup from 4 seconds to 8 seconds. 

Device sleep behavior after will be as follows:
(Changed)
Initial Button Wakeup to Sleep : 8s 
(No Change)
Subsequent Button Action to Sleep : 4s
Leaving RF Field wake to sleep : 3s
BLE Disconnect to sleep : 4s
USB Power Disconnect to sleep : 3s

Example behavior :
User wakes device with Button B (8 Sec to sleep)
User pushes button B again (Now 4 Sec to sleep) 
User Places device in RF field (Maintain wake)
User removes device from RF field (3 sec to sleep)

If user discontinues the user journey at any point, the identified condition will invoke sleep at defined times.
@github-actions
Copy link

You are welcome to add an entry to the CHANGELOG.md as well

@github-actions
Copy link

Built artifacts for commit 7dc3c23

Firmware

Client

@spp2000
Copy link
Contributor

spp2000 commented Sep 16, 2023

Hi @aramova I want to test your delay (very useful for me!) but, if I flash the Ultra APP DFU above, I get the 98605be (master branch fw) that still have 4 sec delay. How to get the DFU package with 8 sec delay?

@aramova
Copy link
Contributor Author

aramova commented Sep 18, 2023

Hi @aramova I want to test your delay (very useful for me!) but, if I flash the Ultra APP DFU above, I get the 98605be (master branch fw) that still have 4 sec delay. How to get the DFU package with 8 sec delay?

You need to fetch and checkout the PR since the devs haven't merged it yet to test...

git clone https://github.com/RfidResearchGroup/ChameleonUltra.git
cd ChameleonUltra/
git fetch origin pull/152/head:pr-152
git checkout pr-152
less firmware/application/src/utils/syssleep.h

Line 7 should now have a value of 8000

@doegox
Copy link
Contributor

doegox commented Sep 24, 2023

thanks! I merged it on top of branch wip_protocol_refresh :
f5b50aa
because main is currently frozen till all clients are ready for wip_protocol_refresh to be merged into main (cf PR #147 ).

@doegox doegox closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants