-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper 14443-4a support #151
Proper 14443-4a support #151
Conversation
Add ATS copy to long press quick clone Fix long press quick clone supporting only 4b uid
You are welcome to add an entry to the CHANGELOG.md as well |
'sak_hex': hex(data[12]).lstrip('0x').rjust(2, '0'), | ||
'atqa_hex': data[13:15].hex().upper() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed .upper()
because it's called anyways by the caller, added space separator for clarity
@@ -20,9 +20,11 @@ def parse_14a_scan_tag_result(data: bytearray): | |||
""" | |||
return { | |||
'uid_size': data[10], | |||
'uid_hex': data[0:data[10]].hex(), | |||
'uid_hex': data[0:data[10]].hex(' '), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added space separator for clarity
Built artifacts for commit 68d465dFirmwareClient |
😬 sorry. |
My fault, should have checked the open PRs before opening one :)
Definitely not in a hurry, feel free to take your time with the protocol refactoring. In the meantime I drafted this PR. |
I pushed your changes as 09eb0d1 on the other PR.
|
Not sure if there were issues while importing my commit onto your branch, but on the PR RATS was correctly sent after cascade, see here, RATS is sent outside the cascade loop.
Good idea, I’d document that clients are expected to validate ATS. |
ha yes, sorry, I copy/pasted too early above "}" |
Automatically send RATS to 14443-4a tags
Add ATS copy to long press quick clone
Fix long press quick clone supporting only 4b uid