forked from ECP-WarpX/WarpX
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PulsarBC and diags #68
Draft
RevathiJambunathan
wants to merge
23
commits into
Pulsar_Development
Choose a base branch
from
Pulsar_BC_CorEInRstar_plus3DR_BdipoleinRstar
base: Pulsar_Development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PulsarBC and diags #68
RevathiJambunathan
wants to merge
23
commits into
Pulsar_Development
from
Pulsar_BC_CorEInRstar_plus3DR_BdipoleinRstar
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RevathiJambunathan
force-pushed
the
Pulsar_Development
branch
from
May 24, 2021 17:01
eae1650
to
824e6c3
Compare
RevathiJambunathan
force-pushed
the
Pulsar_Development
branch
from
September 10, 2021 17:31
824e6c3
to
710edfb
Compare
RevathiJambunathan
force-pushed
the
Pulsar_BC_CorEInRstar_plus3DR_BdipoleinRstar
branch
from
September 10, 2021 23:31
0485e8e
to
31b0cb2
Compare
Source/Diagnostics/ComputeDiagFunctors/PoyntingVectorFunctor.cpp
Outdated
Show resolved
Hide resolved
RevathiJambunathan
force-pushed
the
Pulsar_Development
branch
from
September 15, 2021 17:24
710edfb
to
6f88571
Compare
…tside, momentum of all particles is zero, fixed function that applied vacuum EB fields on particles
* Adding pulsar input and reading pulsar parameters using Don's PR * added external E and B fields and the appropriate input parameters * EOL whitespace * seeting up bounds for pulsar surface * pushing changes for comparison * particles injected below surface, dipole magnetic field inside and outside, momentum of all particles is zero, fixed function that applied vacuum EB fields on particles * add particles based on analytical surface charge density * using local Er and Er_cor to compute particle introduction * fixing particle injection with local Er that includes Er_external * changes to pulsar * michel and li efields inside and outside star. Particle injection rho_GJ * adding input parameters to toggle rho gj scaling, ninjection, maxden * removing unwanted insidePulsarBound function * Damp electric fields internal to the pulsar when compiling with PULSAR on. * Separate out cartesian ijk -> spherical radius into a utility function so it can be used elsewhere. * Add PulsarParm::Omega(t) function that returns omega(t) depending on ramp_omega_time input parameter. If ramp_omega_time < 0, PulsarParm::Omega(t) = omega_star. * Ran the style commands suggested by Travis CI to remove trailing whitespace. * Upsating GetPosition() based on recent changes in master branch * Damp electric fields internal to the pulsar when compiling with PULSAR on. * Undo line removal. * Calling External E and B for pulsar from GetExternal functions * a few fixes in the getexternalEB and addplasma to ensure test works * fixed Ecell * removing particles if inside R_Star * recent input file * eol fix * Add functor for pulsar particle injection * fix eol * Add Functor file * fix eol * add updated input file * push external-EB-on-grid to debug. particle injection off. * inject fixed number of particles when injection is on * adding file with external EM field on grid * fix indent * fixing for loop to include last dimension * add notebook with scaling * fixing E-corotating insdie. E-quad outside. B-dipole everywhere * gather external pulsar fields, add num_ppc particles, damp Maxwell fields inside pulsar * include particles only outside r_star * fix EOL * particle injection inner ring and particle removal in same location * damp EB fields inside R_Star, intro and remove part inside R_star * fix typo in cell cell z coordinate * add fraction of particles through pcounts of cell. * Revert "add fraction of particles through pcounts of cell." This reverts commit f3daa96. * ensuring that fractional particle injection is uniform in cell * we dont need the p.id=-1 to remove particles 1-fractional part injection * updated input file * terminate ifdef PULSAR * remove unnecessary call to add external EB on EB Multifab. we call it directly in Fieldgather instead * clean commented out lines in GetExternalFields * remove commented out code and old unused PulsarEField and PulsarBField * remove unused function init * removing AddPulsarPlasma functor which is not used * remove commented out code and calls to add plasma functor * adding missing ; * FillBoundary for EB after dampingEB * using gpuarray for staggering used to damp EB fields * default values in fieldgather doShapeN for problo, probhi, and cur_time * empty array * pass by reference * take user-defined cc to compute r * Add Dons recommendation to change wt for fractional injection * modifying particle wt, redefining insidePulsarBoundsCC, and removing unnecessary functions * delete redundant function definition * remove redundant function definitions * remove unused variable * remove unnecesary empty line * adding user-inpu for modifying particle weight * querying input for modiyfing particle weight * remove header file decleration in Make package * remove unnecesary header * remove unused function call * use input value of star center to allow for shifted centers in the input * adding a separate file for gather pulsar external EB using grid resolution * removing Pulsar related calls from the core gather functions * call pulsar field gather separate from field gather * deposit charge is modified and therefore not const * reorder function definitions and add missingsemicolon * fix typo of variable in pulsarparameters * add the empty line back * undo any changes in FieldGather so it is the same as WarpX development * remove modifications made to fieldgather * remove unnecessary blank line in at end of file * remove tab * EOL * input parameters for damping EB and external EB to distinguish inside and outside * adding a few more input parameters * adding particle absortion radius as input * remove unnecessary print statement * add min max bounds for defining particle injection region * EOL * fix typo * fix comments from the review Co-authored-by: Donald E. Willcox <[email protected]> Co-authored-by: Revathi Jambunathan <[email protected]>
…he end of the loop
RevathiJambunathan
force-pushed
the
Pulsar_BC_CorEInRstar_plus3DR_BdipoleinRstar
branch
from
September 15, 2021 17:25
a254052
to
47b59db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.