fix warnings

RevathiJambunathan · Dec 30, 2023 · 1cb5453 · 1cb5453
1 parent f7590cc
commit 1cb5453
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/Source/Diagnostics/ComputeDiagFunctors/RecordingPlaneParticleFunctor.H b/Source/Diagnostics/ComputeDiagFunctors/RecordingPlaneParticleFunctor.H
@@ -51,7 +51,7 @@ public:
 
     void operator () (PinnedMemoryParticleContainer& pc_dst, int &TotalParticleCounter, int i_buffer) const override;
 
-    void PrepareFunctorData (const int i_buffer, bool record_particles, amrex::Real z_location, amrex::Real current_z_boost = 0., amrex::Real tlab = 0., int snapshot_full = 0) override;
+    void PrepareFunctorData (int i_buffer, bool record_particles, amrex::Real z_location, amrex::Real current_z_boost, amrex::Real tlab, int snapshot_full) override;
 
 private:
 

diff --git a/Source/Diagnostics/ComputeDiagFunctors/RecordingPlaneParticleFunctor.cpp b/Source/Diagnostics/ComputeDiagFunctors/RecordingPlaneParticleFunctor.cpp
@@ -8,6 +8,7 @@
 
 #include "Particles/Pusher/GetAndSetPosition.H"
 #include "Particles/WarpXParticleContainer.H"
+#include "Utils/TextMsg.H"
 #include "Utils/WarpXConst.H"
 #include "WarpX.H"
 
@@ -65,10 +66,11 @@ RecordingPlaneParticleFunctor::RecordingPlaneParticleFunctor (
                         WarpXParticleContainer *pc_src, std::string species_name, int num_station_buffers)
     : m_pc_src(pc_src), m_species_name(species_name), m_num_station_buffers(num_station_buffers)
 {
+    WARPX_ALWAYS_ASSERT(m_num_station_buffers == 1);
 }
 
 void
-RecordingPlaneParticleFunctor::operator () (PinnedMemoryParticleContainer& pc_dst, int &TotalParticleCounter, int i_buffer) const
+RecordingPlaneParticleFunctor::operator () (PinnedMemoryParticleContainer& pc_dst, int &TotalParticleCounter, int /*i_buffer*/) const
 {
     amrex::Print() << " in station particle operator " << m_record_particles << "\n";
     if (!m_record_particles) return;
@@ -134,7 +136,7 @@ RecordingPlaneParticleFunctor::operator () (PinnedMemoryParticleContainer& pc_ds
 }
 
 void
-RecordingPlaneParticleFunctor::PrepareFunctorData (const int i_buffer, bool record_particles,
+RecordingPlaneParticleFunctor::PrepareFunctorData (int /*i_buffer*/, bool record_particles,
                                             amrex::Real z_location, amrex::Real current_z_boost, amrex::Real tlab, int snapshot_full)
 {
     amrex::ignore_unused(current_z_boost, tlab, snapshot_full);

diff --git a/Source/Diagnostics/RecordingPlaneDiagnostics.cpp b/Source/Diagnostics/RecordingPlaneDiagnostics.cpp
@@ -296,7 +296,7 @@ RecordingPlaneDiagnostics::PrepareParticleDataForOutput ()
     }
     for (int isp = 0; isp < m_all_particle_functors.size(); ++isp)
     {
-        m_all_particle_functors[isp]->PrepareFunctorData(0, GetZSliceInDomain(0), m_station_loc, 0._rt, 0._rt, 0._rt);
+        m_all_particle_functors[isp]->PrepareFunctorData(0, GetZSliceInDomain(0), m_station_loc, 0._rt, 0._rt, 0);
     }
 }
 
@@ -305,7 +305,6 @@ RecordingPlaneDiagnostics::Flush (int i_buffer, bool /* force_flush */)
 {
     if (m_slice_counter == 0) return;
 
-    // const std::string filename = amrex::Concatenate(m_file_prefix, i_buffer, 1);
     const std::string filename = m_file_prefix;
     constexpr int permission_flag_rwxrxrx = 0755;
     if (amrex::ParallelDescriptor::IOProcessor()) {