Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move relationship functionality to Turbo Streams #1421

Merged
merged 9 commits into from
Oct 28, 2023

Conversation

pixeldesu
Copy link
Member

Self-explanatory.

To Do:

  • Remove Ajax::RelationshipController and specs
  • Remove relationship TypeScript functionality
  • Add specs for RelationshipsController

@pixeldesu pixeldesu requested review from nilsding and raccube October 26, 2023 06:19
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0877b93) 95.30% compared to head (e34fda1) 95.34%.

❗ Current head e34fda1 differs from pull request most recent head e802e01. Consider uploading reports for the commit e802e01 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
+ Coverage   95.30%   95.34%   +0.04%     
==========================================
  Files         171      171              
  Lines        2682     2666      -16     
==========================================
- Hits         2556     2542      -14     
+ Misses        126      124       -2     
Files Coverage Δ
app/controllers/relationships_controller.rb 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixeldesu pixeldesu force-pushed the feature/turbo-relationships branch from 6373980 to 78f3daa Compare October 26, 2023 20:23
@pixeldesu pixeldesu marked this pull request as ready for review October 26, 2023 21:15
@raccube raccube force-pushed the feature/turbo-relationships branch from e34fda1 to e802e01 Compare October 28, 2023 08:41
@github-actions github-actions bot added the feature Pull Requests that add a feature label Oct 28, 2023
@raccube raccube merged commit 7424925 into main Oct 28, 2023
12 checks passed
@raccube raccube deleted the feature/turbo-relationships branch October 28, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull Requests that add a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants