Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user content deletion #1397

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Fix user content deletion #1397

merged 4 commits into from
Oct 18, 2023

Conversation

nilsding
Copy link
Member

No description provided.

@nilsding nilsding requested review from pixeldesu and raccube October 18, 2023 19:53
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b8fd519) 95.20% compared to head (c4da510) 95.20%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         168      168           
  Lines        2629     2629           
=======================================
  Hits         2503     2503           
  Misses        126      126           
Files Coverage Δ
app/models/inbox.rb 92.85% <66.66%> (ø)
app/models/notification.rb 92.85% <66.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixeldesu
Copy link
Member

Works, but it now surfaced that the same is also the case for Notification. Procedure of fixing should be exactly the same as with Inbox already.

[ActiveJob] [ActiveRecord::DestroyAssociationAsyncJob] [ba2aaeeb-5f20-4015-9dda-9ef237a55270] Error performing ActiveRecord::DestroyAssociationAsyncJob (Job ID: ba2aaeeb-5f20-4015-9dda-9ef237a55270) from Sidekiq(default) in 102.54ms: NoMethodError (undefined method `touch' for nil:NilClass

    recipient.touch(:notifications_updated_at)
             ^^^^^^):
/app/app/models/notification.rb:16:in `block in <class:Notification>'

https://github.com/Retrospring/retrospring/blob/main/app/models/notification.rb#L16

@nilsding
Copy link
Member Author

nice catch, patched this one too

@nilsding nilsding merged commit 182654d into main Oct 18, 2023
10 of 11 checks passed
@nilsding nilsding deleted the fix-user-content-deletion branch October 18, 2023 20:18
@sentry-io
Copy link

sentry-io bot commented Oct 24, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ActiveRecord::Deadlocked: PG::TRDeadlockDetected: ERROR: deadlock detected (ActiveRecord::Deadlocked) Sidekiq/ActiveRecord::DestroyAssociationAsyncJob View Issue

Did you find this useful? React with a 👍 or 👎

@nilsding
Copy link
Member Author

ja well…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants