Remove superfluous rubocop:disable comments

Retrospring · Oct 15, 2023 · ffcaa5c · ffcaa5c
1 parent 9658f10
commit ffcaa5c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 8 deletions.
diff --git a/app/models/user.rb b/app/models/user.rb
@@ -117,10 +117,8 @@ def member_of?(list) = list_memberships.pluck(:list_id).include? list.id
   # @param question [Question] the question to answer
   # @param content [String] the answer content
   def answer(question, content)
-    # rubocop:disable Style/RedundantSelf
     raise Errors::AnsweringOtherBlockedSelf if question.user&.blocking?(self)
     raise Errors::AnsweringSelfBlockedOther if self.blocking?(question.user)
-    # rubocop:enable Style/RedundantSelf
 
     Retrospring::Metrics::QUESTIONS_ANSWERED.increment
 
@@ -132,10 +130,8 @@ def answer(question, content)
   def answered?(question) = question.answers.pluck(:user_id).include? id
 
   def comment(answer, content)
-    # rubocop:disable Style/RedundantSelf
     raise Errors::CommentingSelfBlockedOther if self.blocking?(answer.user)
     raise Errors::CommentingOtherBlockedSelf if answer.user.blocking?(self)
-    # rubocop:enable Style/RedundantSelf
 
     Retrospring::Metrics::COMMENTS_CREATED.increment
 

diff --git a/app/models/user/reaction_methods.rb b/app/models/user/reaction_methods.rb
@@ -4,10 +4,8 @@ module User::ReactionMethods
   # smiles an answer or comment
   # @param item [ApplicationRecord] the answer/comment to smile
   def smile(item)
-    # rubocop:disable Style/RedundantSelf
     raise Errors::ReactingSelfBlockedOther if self.blocking?(item.user)
     raise Errors::ReactingOtherBlockedSelf if item.user.blocking?(self)
-    # rubocop:enable Style/RedundantSelf
 
     ::Appendable::Reaction.create!(user: self, parent: item, content: "🙂")
   end

diff --git a/app/models/user/relationship/follow.rb b/app/models/user/relationship/follow.rb
@@ -19,10 +19,8 @@ module Follow
       # Follow an user
       def follow(target_user)
         raise Errors::FollowingSelf if target_user == self
-        # rubocop:disable Style/RedundantSelf
         raise Errors::FollowingOtherBlockedSelf if target_user.blocking?(self)
         raise Errors::FollowingSelfBlockedOther if self.blocking?(target_user)
-        # rubocop:enable Style/RedundantSelf
 
         create_relationship(active_follow_relationships, target_user)
       end