add avatar_url to login response, achievement_info response, and leaderboard_info responses #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides plumbing to support RetroAchievements/RAWeb#3017
rc_api_process_login_server_response
,rc_api_process_fetch_achievement_info_server_response
, andrc_api_process_fetch_leaderboard_info_server_response
now returnavatar_url
fields beside theusername
field. These should be used instead of callingrc_api_init_fetch_image_request
with theusername
, as the avatar URL for a user who has changed their display name will not match and the default avatar image will be downloaded instead.rc_client_user_get_image_url
will automatically leverage the newavatar_url
data. Clients usingrc_api_init_fetch_image_request
directly to fetch user images for any purpose should switch to use theavatar_url
value instead.If the server doesn't provide an
avatar_url
(for the brief period until the above PR is deployed), it will be constructed in the same manner as was previously handled byrc_api_init_fetch_image_request
.