Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add avatar_url to login response, achievement_info response, and leaderboard_info responses #393

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jan 20, 2025

Provides plumbing to support RetroAchievements/RAWeb#3017

rc_api_process_login_server_response, rc_api_process_fetch_achievement_info_server_response, and rc_api_process_fetch_leaderboard_info_server_response now return avatar_url fields beside the username field. These should be used instead of calling rc_api_init_fetch_image_request with the username, as the avatar URL for a user who has changed their display name will not match and the default avatar image will be downloaded instead.

rc_client_user_get_image_url will automatically leverage the new avatar_url data. Clients using rc_api_init_fetch_image_request directly to fetch user images for any purpose should switch to use the avatar_url value instead.

If the server doesn't provide an avatar_url (for the brief period until the above PR is deployed), it will be constructed in the same manner as was previously handled by rc_api_init_fetch_image_request.

@Jamiras Jamiras added this to the 11.7.0 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant