Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow client to pass custom errors through http callback #285

Merged

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Oct 23, 2023

More generic solution for #283

The client can set rc_api_server_response_t.http_status_code to RC_API_SERVER_RESPONSE_CLIENT_ERROR or RC_API_SERVER_RESPONSE_RETRYABLE_CLIENT_ERROR and then put the error message in rc_api_server_response_t.body.

RC_API_SERVER_RESPONSE_RETRYABLE_CLIENT_ERROR indicates a non-fatal error (such as timeout) that should be retried for critical messages like achievement unlocks.

@Jamiras Jamiras added this to the 11.0.0 milestone Oct 23, 2023
@Jamiras Jamiras merged commit 491d881 into RetroAchievements:develop Oct 28, 2023
@Jamiras Jamiras deleted the feature/http_callback_client_error branch October 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant