better handling of wininet errors (#283)

RetroAchievements · Oct 23, 2023 · 6c2e98f · 6c2e98f
1 parent 3d99026
commit 6c2e98f
Show file tree

Hide file tree

Showing 2 changed files with 123 additions and 241 deletions.
diff --git a/src/rc_client.c b/src/rc_client.c
@@ -350,6 +350,16 @@ static const char* rc_client_server_error_message(int* result, int http_status_c
 
     if (response->error_message)
       return response->error_message;
+
+#ifdef _WIN32
+    switch (http_status_code) {
+      case 12002: return "Request has timed out.";
+      case 12007: return "Server name could not be resolved.";
+      case 12029: return "Could not connect to server.";
+      case 12163: return "Connection has been lost.";
+      default: break;
+    }
+#endif
   }
 
   if (*result != RC_OK)
@@ -461,6 +471,52 @@ static int rc_client_should_retry(const rc_api_server_response_t* server_respons
       /* connection to server from cloudfare was dropped before request was completed */
       return 1;
 
+#ifdef _WIN32
+    case 12002: /* ERROR_INTERNET_TIMEOUT */
+      /* timeout */
+      return 1;
+
+    case 12007: /* ERROR_INTERNET_NAME_NOT_RESOLVED */
+      /* DNS lookup failed */
+      return 1;
+
+    case 12017: /* ERROR_INTERNET_OPERATION_CANCELLED */
+      /* Handle closed before request complete */
+      return 1;
+
+    case 12019: /* ERROR_INTERNET_INCORRECT_HANDLE_STATE */
+      /* Handle not initialized */
+      return 1;
+
+    case 12028: /* ERROR_INTERNET_ITEM_NOT_FOUND */
+      /* Data not available at this time */
+      return 1;
+
+    case 12029: /* ERROR_INTERNET_CANNOT_CONNECT */
+      /* Handshake failed */
+      return 1;
+
+    case 12030: /* ERROR_INTERNET_CONNECTION_ABORTED */
+      /* Connection aborted */
+      return 1;
+
+    case 12031: /* ERROR_INTERNET_CONNECTION_RESET */
+      /* Connection reset */
+      return 1;
+
+    case 12032: /* ERROR_INTERNET_FORCE_RETRY */
+      /* Explicit request to retry */
+      return 1;
+
+    case 12152: /* ERROR_HTTP_INVALID_SERVER_RESPONSE */
+      /* Response could not be parsed, corrupt ? */
+      return 1;
+
+    case 12163: /* ERROR_INTERNET_DISCONNECTED */
+      /* Lost connection during request */
+      return 1;
+#endif
+
     default:
       return 0;
   }
@@ -840,6 +896,8 @@ static void rc_client_load_error(rc_client_load_state_t* load_state, int result,
 
   rc_mutex_unlock(&load_state->client->state.mutex);
 
+  RC_CLIENT_LOG_ERR_FORMATTED(load_state->client, "Load failed (%d): %s", result, error_message);
+
   if (load_state->callback)
     load_state->callback(result, error_message, load_state->client, load_state->callback_userdata);