Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add search page #73

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[WIP] Add search page #73

wants to merge 12 commits into from

Conversation

nth-chile
Copy link

@nth-chile nth-chile commented Oct 16, 2023 •
edited
Loading

480.mov

Why

  • Search for all versions of a song, so you don't have to click through a bunch of shows to find them
  • We could add artists to Relisten without showing them in the featured artists column, and still have them available if you search for them. There would be less of a reason to be selective about which artists to add

Todo

  • Before the user has entered a search query, the main section of the page should show the list of featured artists. Like Spotify
  • Do we need to sanitize/trim search input?
  • Add real duration for song versions list, I couldn't find it in the API response

@nth-chile nth-chile marked this pull request as draft October 16, 2023 14:52
nth-chile
nth-chile commented Oct 16, 2023
View reviewed changes
src/app/(main)/NavBar.tsx
<Link href="/search" legacyBehavior prefetch={false}>
<a className="nav-btn">SEARCH</a>
</Link>
</div>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running out of room on the nav. This goes behind the player

nth-chile
nth-chile commented Oct 16, 2023
View reviewed changes
src/components/Search.tsx Outdated

useDebouncedEffect(
() => {
// TODO: sanitize, trim ...
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepare the string so it's always a valid param

@nth-chile nth-chile marked this pull request as ready for review January 5, 2024 23:33
@nth-chile nth-chile changed the title WIP: Add search page [WIP] Add search page May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@switz switz switz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nth-chile @switz