-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add RecentlyPurchasedFacet #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
byUser: purchaseQualifiers.byUser ?? false, | ||
byUserCompany: purchaseQualifiers.byUserCompany ?? false, | ||
byUserParentCompany: purchaseQualifiers.byUserParentCompany ?? false, | ||
sinceMinutesAgo: purchaseQualifiers.sinceMinutesAgo ?? 1234, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for these fallbacks? Values are required right?
The 1234
seems like test code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det er helt klart noget jeg har glemt at fjerne ja! Det er nu rettet.
Co-authored-by: Martin Zanoni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.