Feat: implements product search constraints #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzanoni
requested changes
Aug 12, 2024
Comment on lines
7
to
10
| this.resultConstraint = { | ||
| $type: 'Relewise.Client.Requests.Search.Settings.ResultMustHaveVariantConstraint, Relewise.Client', | ||
| ...constaint, | ||
| } as ResultMustHaveVariantConstraint; |
There was a problem hiding this comment.
Suggested change
| this.resultConstraint = { | |
| $type: 'Relewise.Client.Requests.Search.Settings.ResultMustHaveVariantConstraint, Relewise.Client', | |
| ...constaint, | |
| } as ResultMustHaveVariantConstraint; | |
| this.resultConstraint: ResultMustHaveVariantConstraint = { | |
| $type: 'Relewise.Client.Requests.Search.Settings.ResultMustHaveVariantConstraint, Relewise.Client', | |
| ...constaint, | |
| }; |
Using cast by parses a ton of the Typescript type-checks and should be avoided when possible, like it is here :)
There was a problem hiding this comment.
This syntax is invalid here!
There was a problem hiding this comment.
Just assign it to a local const variable before assigning to this.resultConstraint
packages/client/tests/unit-tests/builders/search/productSearchBuilder.unit.test.ts
Show resolved
Hide resolved
mzanoni
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.