Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/split-filterbuilder-into-individual-builders #63

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

RAORelewise
Copy link
Contributor

@RAORelewise RAORelewise commented Jun 27, 2024

Trello: https://trello.com/c/BBJVcWyv/6777-js-sdk-split-filterbuilder-up-into-respective-builders-eg-productfilterbuilder-contentfilterbuilder

To prevent having 1 large bloated filterBuilder we extract each filter type into their own builder, which means tree-shaking wise we can reduce bundle size if we only use Product filters for example.

Also introduced base filter builder class and made it easier to get all the filter types.

@RAORelewise RAORelewise requested a review from mzanoni June 27, 2024 10:24
Copy link
Collaborator

@mzanoni mzanoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stærkt!

@mzanoni mzanoni merged commit eeb8b6e into main Jun 27, 2024
2 checks passed
@mzanoni mzanoni deleted the feature/split-filterbuilder-into-individual-builders branch June 27, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants