Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cancellation support #43

Merged
merged 11 commits into from
Oct 23, 2023
Merged

feat: cancellation support #43

merged 11 commits into from
Oct 23, 2023

Conversation

RAORelewise
Copy link
Contributor

@RAORelewise RAORelewise commented Oct 20, 2023 •
edited
Loading

No description provided.

@RAORelewise RAORelewise requested a review from mzanoni October 20, 2023 08:37
mzanoni
mzanoni requested changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@mzanoni mzanoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mega fedt. :)

Ligenu er det kun Tracker, som ikke har den nye RequestOptions-type, kunne vi ikke lige så godt tage i mod den, som en ekstra parameter der også?

Så har vi lavet infrastruktur på alle typerne til at kunne udvide functionalitet mod fetch

lib/src/relewise.client.ts Outdated Show resolved Hide resolved
@RAORelewise RAORelewise requested a review from mzanoni October 23, 2023 06:28
mzanoni
mzanoni approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@mzanoni mzanoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smuuuuuuuuukt! ❤️

@mzanoni mzanoni merged commit a370f32 into main Oct 23, 2023
1 check passed
@mzanoni mzanoni deleted the feat-cancellation-support branch October 23, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzanoni mzanoni mzanoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RAORelewise @mzanoni