Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitHub actions #389

Merged
merged 19 commits into from
Oct 9, 2024
Merged

Move to GitHub actions #389

merged 19 commits into from
Oct 9, 2024

Conversation

iddm
Copy link
Collaborator

@iddm iddm commented Oct 1, 2024

No description provided.

@iddm iddm changed the title Draft: Move to GitHub actions Move to GitHub actions Oct 1, 2024
@iddm
Copy link
Collaborator Author

iddm commented Oct 1, 2024

I don't know why the macos-latest or macos-14 runners aren't picking up the macos jobs, maybe today is a bad day?

The tests currently use Redis 7.2 for all the features. I think the best way is actually to use the versions equal to the features, but those fail.

@iddm iddm force-pushed the MOD-7747-move-to-github-actions branch from 40e831e to 675a308 Compare October 7, 2024 11:51
Copy link
Contributor

@ephraimfeldblum ephraimfeldblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. good job with removing the makefile and readies.

@iddm iddm removed the request for review from MeirShpilraien October 7, 2024 14:13
@iddm iddm closed this Oct 8, 2024
@iddm iddm reopened this Oct 8, 2024
@iddm iddm merged commit f142b9c into master Oct 9, 2024
32 checks passed
@iddm iddm deleted the MOD-7747-move-to-github-actions branch October 9, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants