-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to remove expiration for RedisKeyWritable #276
Conversation
Ping, any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@MeirShpilraien Can you please take a look? I just rebased the change. |
@QuChen88 maybe we can add a test for the new functionality? |
I can't seem to find an existing test for the What is the convention for adding such a test? Can you point me to an example? |
@QuChen88 what we usually do is adding a simple example module under the example directory, the module can expose a simple command that uses the new functionality (like a command that remove expiration from a key). Then we add a test that loads the module and check the functionality here: https://github.com/RedisLabsModules/redismodule-rs/blob/master/tests/integration.rs |
eeff3a8
to
49d4179
Compare
freebds flow seems broken (stuck). Merging without it (tests pass on the other flows). |
Thanks @QuChen88 |
Currently
RedisKeyWritable
has no easy way to remove expiration/TTL from a key that already exists in Redis becauseset_expire()
takesDuration
as input even though the underlyingraw::set_expire()
method supports this functionality.This PR adds a new method
remove_expire()
toRedisKeyWritable
.