Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new field and changed its data structure #6

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

cekk
Copy link
Member

@cekk cekk commented Jan 31, 2024

…and changed its data structure

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7726383369

  • -4 of 24 (83.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 90.441%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/voltoplugin/editablefooter/restapi/deserializer.py 6 8 75.0%
src/redturtle/voltoplugin/editablefooter/restapi/get.py 9 11 81.82%
Totals Coverage Status
Change from base Build 7556067794: -1.6%
Covered Lines: 123
Relevant Lines: 136

💛 - Coveralls

profile="redturtle.voltoplugin.editablefooter:default"
source="1000"
destination="1001"
handler=".upgrades.update_registry"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are updating the registry, but I don't see any files added/changed, did you forget in the commit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added a new field in interfaces.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and you need to reload the registry profile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know (never done) if there is a way to add it manually

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik you need to reload registry

@mamico mamico changed the title Add new field and Rename service endpoint to *@editable-footer-data* … Add new field and changed its data structure Mar 4, 2024
@cekk cekk merged commit 1184665 into main Mar 7, 2024
4 checks passed
@cekk cekk deleted the add_footer_top branch March 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants