Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volto.formsupport path to not alter returned data on POST. #74

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

cekk
Copy link
Member

@cekk cekk commented Dec 10, 2024

The problem was that with enabled "store data" flag, the patch changed the POST response data structure, and the frontend cannot read submitted data for the thank-you page:

Standard response:

{
 "data": {....}
}

Response with store data flag:

{
  "data": {
    "form_data": {...}
}

With this pr we don't change where the data is stored, so frontend will always get it.

This is related to italia/design-comuni-plone-theme#192

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12258692351

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 55.995%

Totals Coverage Status
Change from base Build 12177079948: 0.1%
Covered Lines: 495
Relevant Lines: 884

💛 - Coveralls

@luca-bellenghi luca-bellenghi merged commit 07fe2d7 into main Dec 16, 2024
9 checks passed
@luca-bellenghi luca-bellenghi deleted the cekk_fix_formsupport_patch branch December 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants